Smartcookie, it is a troubling question isn’t it. But what happened to him in Israel has nothing to do with who he is today, what kind of husband or father he would make. He made a huge mistake back then and it has no shaychus to today at all. Absolutely nothing. He made a mistake and he paid for it big time. He learned a huge lesson from it. How could revealing this information be helpful to anyone? Why should knowing this information change a girl’s mind about marrying or even dating him. It is not something he would ever do in his adult life, nothing he would ever revisit again. So how would divulging this information be helpful to anyone? This is something he would have to inform a girl after dating her for a while and she gets to know him. He would have to say to her “There is something I need to tell you. I made a really stupid mistake when I was a kid and I learned a huge lesson from it. I hope it won’t scare you off. I don’t want to hide anything about myself from you and I don’t want you to hear it from someone else, but it has nothing to do with who I am today it was just something so stupid that I did when I was a kid and I am so ashamed about”.
Maybe he should even introduce her to his Rav and tell her this in front of him so he can help him and answer any questions the girl has and then offer to answer any questions the girls parents might have about the incident.
So you see, every single situation has a twist and a turn. Nothing is simple and every single situation has to be handled with kid gloves on its own merit. If I were to tell a hyper person about this incident word could get out on this young man that he is a drug dealer and ruin his entire reputation. He could even get kicked out of Law school and ruin his chances of a good career. And for what reason because he made a mistake when he was 18? Now he is a man of 25 with a lot more seichel. Should he suffer for his mistakes for the rest of his life?