It helped Trump with several groups, including Evangelicals. It also reassured Israel that the US won’t demand a withdrawal to the 1947 partition boundaries (under which Jerusalem wouldn’t be part of Israel). In addition to Christians, much of Trump’s base sees the Palestinians as supporters of Islamic terrorism and the embassy move was a slap in the Palestinians’ face. As most Jews live in solid blue states, Jewish influence on American politics is minimal, so the decision to move the embassy wasn’t motivated by a desire to get Jewish votes.
Given that he didn’t disown his daughter for converting, I would say he is definitely a friend. Most Democrats believe in “freedom from religion” as a public policy goal.