Can we all agree that comparing smoking to being OTD was probably not meant literally and probably was a poor choice of words?
The larger point however is valid. Obviously, smoking is not a good habit and it is certainly reasonable to say it is a strike against a person, and for some people, it may be a deal breaker, but everyone has their own deal breakers.
I also note that as with many things, times have changed, so any reference to people who grew up in the past and struggled with smoking when it was more common is not relevant (except to the point about it being like OTD, which I don’t think the poster really meant). I went to Hebrew Academy and the rabbi who served us the kosher food and his wife smoked (not while serving, but there was a stench). It bothered some then, it would be unheard of now.
And today, I think an inference can be drawn that someone who smokes is more of a rebel than in the past, when it was quite common. Of course, like anything else, there are exceptions, but it is a fair generalization if not an absolute rule.