“Is using American citizens employed in American national security to spy against America on American soil or the Israeli prime minister coming to America to speak against the president a form of hakaras hatov? “
Probably not. But I think Israel’s responsibility to keep its citizens safe is probably more important than hakaras hatov. And Israel has other ways of showing hakaras hatov as other posters mentioned- intelligence sharing and a strategic ally in the hostile Middle East.