Francorachel3,
Are we not creating a generation of spoiled children?
I see it in almost the exact opposite way. If a family has the means to pay for a lavish vacation that their kids will love, why not use those funds to elevate their joy of Yom Tov?
Just for the record, we stay home for Pesach every year.